Request for review (XL): 6822110: Add AddressLiteral class on SPARC

[Tom Rodriguez]

icBuffer_sparc.cpp:

I believe we could the special reloc stuff completely here.  Passing  
ForceRelocatable = true is useless assuming the rest of the comments  
are right about not needing a reloc at all.  Could we remove the  
ForceRelocatable version of sethi completely in favor of requiring the  
use of AddressLiteral?

interp_masp_sparc.cpp:

you dropped the minus below:

-  Address d_save(FP, 0, -sizeof(jdouble) + STACK_BIAS);
+  Address d_save(FP, sizeof(jdouble) + STACK_BIAS);

for this:

Address lock_addr = Address(

it should just be:

Address lock_addr(

assembler_sparc.hpp:

why does load_contents take 2 registers?  All uses pass the same thing  
for both.  It should just assume the dest is the temp.  Actually I  
think that's true of all the new ones that take both a temp and a dest.

Otherwise I think this looks good.

tom

On Mar 27, 2009, at 4:26 PM, Christian Thalinger wrote:

> On Wed, 2009-03-25 at 22:18 -0700, Christian Thalinger wrote:
>>> You need to pull latest changesets:
>>> John changed RegisterConstant to RegisterOrConstant
>>
>> Ahh, right.  Thanks for reminding.
>
> Here is an updated version of the patch:
>
> http://cr.openjdk.java.net/~twisti/6822110/webrev.01/
>
> -- Christian
>