Request for reviews (L): 6823354: Add intrinsics for{Integer,Long}.{numberOfLeadingZeros,numberOfTrailingZeros}()

Tom Rodriguez Thomas.Rodriguez at Sun.COM
Tue May 5 11:28:16 PDT 2009


I think returning TypeInt::INT directly would be preferred.   
bottom_type() is always virtual and you have to look elsewhere to see  
what it returns.

tom

On May 5, 2009, at 9:15 AM, Christian Thalinger wrote:

> On Tue, 2009-05-05 at 09:10 -0700, Vladimir Kozlov wrote:
>> It is the same since bottom_type() returns TypeInt::INT:
>>
>> + class CountBitsNode : public Node {
>> + public:
>> +   CountBitsNode(Node* in1) : Node(0, in1) {}
>> +   const Type* bottom_type() const { return TypeInt::INT; }
>
> Right, sorry.  Then I will use bottom_type().
>
> -- Christian
>




More information about the hotspot-compiler-dev mailing list