review (XS) for 6838154: make/linux/makefiles/sa.make needs hash-style fix
Tom Rodriguez
Thomas.Rodriguez at Sun.COM
Wed May 6 13:57:01 PDT 2009
That's a good catch. ldd -r libjsig.so results in the SIGFPE
problem. I'll add that. I ldd -r'd all the other libs in the image
to make sure no others had problems and that seems to be it. I've
updated the webrev.
tom
On May 6, 2009, at 1:42 PM, John Rose wrote:
> Your fix looks fine.
>
> There is a similar one-off pattern in jsig.make. Both supply flags
> to ld via cc, going through $(CC) not through $(LINK.c). Only
> LINK.c picks up $(LFLAGS) and the required hash option. Do you
> think jsig needs a similar fix also?
>
> -- John
>
> On May 6, 2009, at 12:41 PM, Tom Rodriguez wrote:
>
>> http://cr.openjdk.java.net/~never/6838154
>
More information about the hotspot-compiler-dev
mailing list