Request for reviews .02 (L): 6814842: Load shortening optimizations

Tom Rodriguez Thomas.Rodriguez at Sun.COM
Mon May 11 13:38:33 PDT 2009


I don't think the assert in formssel.cpp is needed because it  
replicates the logic in this test that guards enabling cisc spill.   
I'd given that to you originally before I fully realized what was  
going wrong.

1127     if( def_oper == NameList::Not_in_list && instr->num_opnds()  
== num_opnds()) {

in sparc.ad you use simm13 instead of 13 bit in the comments since  
that's the sparc terminology.

otherwise it looks fine.

tom

On May 11, 2009, at 8:23 AM, Christian Thalinger wrote:

> http://cr.openjdk.java.net/~twisti/6814842/webrev.02/
>
> Here is an updated version because, as I noticed last Thursday after
> some testing, that ADLC has a bug and Tom fixed that for me.
>
> -- Christian
>




More information about the hotspot-compiler-dev mailing list