Request for reviews .03 (L): 6814842: Load shortening optimizations

Tom Rodriguez Thomas.Rodriguez at Sun.COM
Tue May 12 09:23:21 PDT 2009


looks good.

tom

On May 12, 2009, at 3:02 AM, Christian Thalinger wrote:

> On Mon, 2009-05-11 at 13:38 -0700, Tom Rodriguez wrote:
>> I don't think the assert in formssel.cpp is needed because it
>> replicates the logic in this test that guards enabling cisc spill.
>> I'd given that to you originally before I fully realized what was
>> going wrong.
>
> I removed the assert.
>
>>
>> 1127     if( def_oper == NameList::Not_in_list && instr->num_opnds()
>> == num_opnds()) {
>>
>> in sparc.ad you use simm13 instead of 13 bit in the comments since
>> that's the sparc terminology.
>
> I changed the ones I added, the others are just copied.
>
> http://cr.openjdk.java.net/~twisti/6814842/webrev.03/
>
> -- Christian
>




More information about the hotspot-compiler-dev mailing list