review (M) for 6892658: C2 should optimize some stringbuilder patterns

[Andreas Kohn]

On Mon, 2009-11-09 at 15:46 -0800, Tom Rodriguez wrote:
> http://cr.openjdk.java.net/~never/6892658/
Hi,

more question a question than a review: should match_F_Y() not require
synchronized?

 306 inline bool match_F_Y(jshort flags) {
 307   const int req = 0;
                     = JVM_ACC_SYNCHRONIZED; ?
 308   const int neg = JVM_ACC_STATIC;
 309   return (flags & (req | neg)) == req;
 310 }

I'm just a casual reader, so I might be missing something here. 

Regards,
--
Andreas

-- 
Never attribute to malice that which can be adequately explained by
stupidity.                                        -- Hanlon's Razor
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
Url : http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20091110/8bc3c6d7/attachment.bin