review (M) for 6892658: C2 should optimize some stringbuilder patterns

[Vladimir Kozlov]

Yes, enum is fine.

Vladimir

Tom Rodriguez wrote:
>>>> Why 6 is limit for constant strings? Add some comments.
>>> Ok. It's just a number.  6 seems like an ok code space vs. speed tradeoff.
>> May be we should have it as flag or definition to be more visible?
> 
> A flag seems excessive.  It's not like this is a critical tunable.  I can move it into an enum in PhaseStringOpts if you like.
> 
>   enum {
>     // max length of constant string copy unrolling in copy_string                                                          
>     unroll_string_copy_length = 6
>   };
> 
> tom
> 
>>>>
>>>> Tom Rodriguez wrote:
>>>>> http://cr.openjdk.java.net/~never/6892658/
>