Request reviews (S): 6902036: WorldWind asserts on escape.cpp:1153: assert(addr->is_AddP(),"AddP required")
Christian Thalinger
Christian.Thalinger at Sun.COM
Thu Nov 19 02:29:09 PST 2009
On Wed, 2009-11-18 at 09:02 -0800, Vladimir Kozlov wrote:
> http://cr.openjdk.java.net/~kvn/6902036/webrev.00
>
> Fixed 6902036: WorldWind asserts on escape.cpp:1153: assert(addr->is_AddP(),"AddP required")
>
> Problem:
> AddPNode::Ideal() may replace AddP node with CastX2P node
> for a raw memory reference. EA code does not check such case.
>
> Solution:
> Check and ignore raw memory operations in EA.
Looks good to me. At least I can tell that WorldWind works with that
fix.
-- Christian
More information about the hotspot-compiler-dev
mailing list