review (S) for 6885584: A particular class structure causes large allocation spike for jit

[Tom Rodriguez]

On Oct 6, 2009, at 5:14 PM, Vladimir Kozlov wrote:

> Tom,
>
> For longs it is possible that max < max_juint.
> So can we change the next condition:

You're right.  I recoded it as:

           if (max >= max_juint && _hi < max_juint)

tom

>
>            if (_hi < max_juint)
>              return make(_lo, max_juint, WidenMax);
>            else
>              return make(_lo, max, WidenMax);
> to next?:
>
>            if (_hi < max_juint && max_juint < max)
>              return make(_lo, max_juint, WidenMax);
>            else
>              return make(_lo, max, WidenMax);
>
> Vladimir
>
> Tom Rodriguez wrote:
>> On Oct 6, 2009, at 4:42 PM, Vladimir Kozlov wrote:
>>> Tom, why changes are different for Int and Long?
>>> For longs you replaced max_jlong, min_jlong with max,min
>> I did them separately and didn't notice that they were different.   
>> I've fixed them to be the same.
>> tom
>>> in make() parameters and conditions.
>>>
>>> Vladimir
>>>
>>> Tom Rodriguez wrote:
>>>> http://cr.openjdk.java.net/~never/6885584