Request for reviews (S): 6889656: assert(lo_lrg->lo_degree() || !lo_no_simplify,"Live range was lo-degree before coalesce

Vladimir Kozlov Vladimir.Kozlov at Sun.COM
Fri Oct 9 09:37:01 PDT 2009


Ok. I will just restore the original code for bounds.

Thanks,
Vladimir

Tom Rodriguez wrote:
> 
> On Oct 9, 2009, at 7:44 AM, Vladimir Kozlov wrote:
> 
>>
>> http://cr.openjdk.java.net/~kvn/6889656/webrev.00
>>
>> Fixed 6889656: assert(lo_lrg->lo_degree() || !lo_no_simplify,"Live 
>> range was lo-degree before coalesce
>>
>> Problem:
>> Because of initial loop's "i" value change in 6875959 fix
>> the first _hi_degree lrg was not checked for lo_degree().
>>
>> Solution:
>> Restore the original code: uint i = _hi_degree.
> 
> I missed that you changed the bounds in the original review.
> 
>> I also cached calculation of live ranges.
> 
> I don't really see the motivation for this and I'd prefer that this fix 
> to a fix just contained the fix and not other stuff, particularly since 
> the last bug was caused by "optimizing" the original code.
> 
> tom
> 
>>
>> Reviewed by:
>>
>> Fix verified (y/n): y, bug's test
>>
>> Other testing:
>> JPRT
>>
> 


More information about the hotspot-compiler-dev mailing list