Request for reviews (M): 6829192: JSR 292 needs to support 64-bit x86
Vladimir Kozlov
Vladimir.Kozlov at Sun.COM
Tue Oct 20 17:32:24 PDT 2009
src/cpu/x86/vm/interp_masm_x86_64.cpp:
In InterpreterMacroAssembler::get_cache_index_at_bcp() the assert
is not clear. Add comment and explain what you are testing to how
next instruction should be changed.
src/cpu/x86/vm/templateInterpreter_x86_64.cpp:
In TemplateInterpreterGenerator::generate_WrongMethodType_handler()
what rbx and rax contain and why you need to verify oop?
I don't like outline code in generate_return_entry_for().
Why do you need to move it down?
src/share/vm/classfile/classFileParser.cpp:
Don't leave commented code. Remove it if you don't need it.
Vladimir
Christian Thalinger wrote:
> Let's start the review round with a patch that does not fit logically
> into the order but is small:
>
> http://cr.openjdk.java.net/~twisti/6829192/webrev.01/
>
> -- Christian
>
More information about the hotspot-compiler-dev
mailing list