Request for review .02 (XS): 6893554: SPECjvm2008 mpegaudio fails with SecurityException

Vladimir Kozlov Vladimir.Kozlov at Sun.COM
Fri Oct 23 11:44:35 PDT 2009


Looks good.

Thanks,
Vladimir

Christian Thalinger wrote:
> On Fri, 2009-10-23 at 19:44 +0200, Christian Thalinger wrote:
>> On Fri, 2009-10-23 at 10:35 -0700, Vladimir Kozlov wrote:
>>> I would just remove #ifdef and use extra shift always.
>>> One additional instruction will not affect performance but
>>> will guaranty the correctness since in 32-bit VM the upper
>>> bit of src register could be set also.
>> Good point.  I will remove the #ifdef and post another webrev.
> 
> http://cr.openjdk.java.net/~twisti/6893554/webrev.02/
> 
> -- Christian
> 


More information about the hotspot-compiler-dev mailing list