Request for reviews (XS): 6880052

Vladimir Kozlov Vladimir.Kozlov at Sun.COM
Tue Sep 8 16:53:25 PDT 2009


Thanks Tom

Vladimir

Tom Rodriguez wrote:
> looks good.
> 
> tom
> 
> On Sep 8, 2009, at 4:15 PM, Vladimir Kozlov wrote:
> 
>>
>> http://cr.openjdk.java.net/~kvn/6880052/webrev.00
>>
>> Fixed 6880052: SIGSEGV in GraphKit::null_check_common()
>>
>> Problem:
>> After 6875577 fix the method do_null_check() checks for
>> unloaded klass also for arrays. But array type may not
>> have klass, for example, when element type is Bottom.
>> The bug case has Phi node which merges several CheckCastPP
>> with different types so its type is bottom[int:>=0].
>>
>> Solution:
>> Check that a klass is not NULL before the unloaded check.
>>
>> Reviewed by:
>>
>> Fix verified (y/n): y, test
>>
>> Other testing:
>> JPRT
>>
> 


More information about the hotspot-compiler-dev mailing list