Request for reviews (L) (resending): 6827605 and 6875866 for HS17

[Tom Rodriguez]

looks good.

tom

On Sep 11, 2009, at 10:10 AM, Vladimir Kozlov wrote:

> I still need reviews for this (and I merged it with latest sources).
>
> http://cr.openjdk.java.net/~kvn/6827605/webrev.02
>
> Fixed 6827605: new String intrinsics may prevent EA scalar replacement
> Fixed 6875866: Intrinsic for String.indexOf() is broken on x86 with  
> SSE4.2
>
> Problem:
> New String.indexOf SSE4.2 intrinsic prevents EA scalar replacement
> of String object clone in the famous hot jbb code in  
> Orderline.process:
> stockData.indexOf("ORIGINAL") (6827605).
> Also String.indexOf SSE4.2 code starts string rescanning from
> a wrong place after failing to match a part of substring (6875866).
>
> Solution:
> Modify String intrinsic methods to pass char[] pointers and
> counters instead of string oops to allow EA eliminate
> non-escaping string objects. Move some checks from
> mach nodes encoding into ideal graph.
> Move common assembler code into MacroAssembler.
> Add memory edge to AryEqNode.
> Fix 6875866.
>
> Reviewed by:
>
> Fix verified (y/n): y, refworkload
>
> Other testing:
> JPRT, CTW
>