Request for reviews (S): 6879921: CTW failure jdk6_18/hotspot/src/share/vm/utilities/globalDefinitions.cpp:268

Changpeng Fang Changpeng.Fang at Sun.COM
Tue Sep 15 10:07:46 PDT 2009


http://cr.openjdk.java.net/~cfang/6879921/webrev.00/

Problem:
We do not intend to apply superword to non-primitive types. Current 
SuperWord
implementation filters out non-primitives when it creates the initial 
set of
packs through "find_adjacent_refs". However, when it extends the packlists
using the def-use or use-def chains, non-primitives may still be put into
consideration, and this leads to the assertion failure when we compute the
data size of a T_ADDRESS type (bug 6879921).

Solution:
Filter out non-primitives when we extend the initial packlists (i.e. 
don't consider
packing non-primitive defs and uses).

Fixes 6879921: CTW failure 
jdk6_18/hotspot/src/share/vm/utilities/globalDefinitions.cpp:268

Tests:
JPRT and CTW

Thanks,

Changpeng


More information about the hotspot-compiler-dev mailing list