Request for reviews (XS): 6879362
Vladimir Kozlov
Vladimir.Kozlov at Sun.COM
Tue Sep 15 18:52:45 PDT 2009
I updated webrev and ran jbb and microbenchmarks to verify that
this change does not have regression in allocation elimination.
Vladimir
Vladimir Kozlov wrote:
> Yes, the equals check could be removed now.
>
> Thanks,
> Vladimir
>
> Tom Rodriguez wrote:
>> Doesn't !is_subtype_of imply !equals?
>>
>> tom
>>
>> On Sep 15, 2009, at 5:44 PM, Vladimir Kozlov wrote:
>>
>>>
>>> http://cr.openjdk.java.net/~kvn/6879362/webrev.00
>>>
>>> Fixed 6879362: assert(!klass_is_exact(),"only non-exact klass")
>>>
>>> Problem:
>>> The AddP type could be not related to the type of
>>> allocated object when CHA type is different from MDO type
>>> on a dead path (for example, from instanceof check)
>>> which is not collapsed during parsing.
>>>
>>> Solution:
>>> Do nothing for such AddP node and don't process its users
>>> during escape analysis since this code branch will go away.
>>>
>>> Reviewed by:
>>>
>>> Fix verified (y/n): y, test
>>>
>>> Other testing:
>>> JPRT
>>>
>>
More information about the hotspot-compiler-dev
mailing list