Request for reviews (XXS): 6940520: CodeCache::scavenge_root_nmethods_do must fix oop relocations

Vladimir Kozlov vladimir.kozlov at oracle.com
Fri Apr 2 08:50:52 PDT 2010


Looks good.

Vladimir

Christian Thalinger wrote:
> http://cr.openjdk.java.net/~twisti/6940520/webrev.01/
> 
> 6940520: CodeCache::scavenge_root_nmethods_do must fix oop relocations
> Summary: ScavengeRootsInCode can lead to unfixed code-embedded oops.
> Reviewed-by:
> 
> During testing of JSR 292's SPARC C2 port I found a couple of crashes
> which came from unfixed code-embedded oops.
> 
> This can be triggered with ScavengeRootsInCode={1,2}.
> 
> The fix is to call fix_oop_relocations in
> CodeCache::scavenge_root_nmethods_do after oops may have been updated.
> 
> src/share/vm/code/codeCache.cpp
> 
> 


More information about the hotspot-compiler-dev mailing list