Request for reviews (M): 6939196: method handle signatures off the boot class path get linkage errors

[Christian Thalinger]

On Tue, 2010-03-30 at 04:06 -0700, John Rose wrote:
> 6939196: method handle signatures off the boot class path get linkage errors
> 
> http://cr.openjdk.java.net/~jrose/6939196/hs-webrev.00/
> http://cr.openjdk.java.net/~jrose/6939196/jdk-webrev.00/
> 
> The bugtraq description is copied below.
> 
> - Adjust MethodType lookup logic to search off the BCP, but not to cache those results.
> - Pass accessing class where it needs to be seen.
> - A SignatureStream idiom "as_klass" for class lookup has been refactored.

src/share/vm/classfile/systemDictionary.cpp:

2382   bool is_on_bcp;  // keep this true as long as we can materialize from the boot classloader

Why do need an extra flag?  return_bcp_flag seems to always be set to
the same value.

src/share/vm/prims/methodHandles.cpp:

441       (//defc() == SystemDictionary::InvokeDynamic_klass() || //FIXME

What is the problem here?

Otherwise looks good.

> 
> Please review the JDK changes along with the JVM changes.  They are very simple:
> - Remove workaround from MethodHandleImpl lookup code
> - Add JUnit regression test to MethodHandlesTest

These changes look good.

-- Christian