Request for reviews (M): 6930772: JSR 292 needs to support SPARC C1
Tom Rodriguez
tom.rodriguez at oracle.com
Fri Apr 9 11:06:31 PDT 2010
I don't like the way this is structured. Why not move the preserve/restore SP logic up into the LIR as regular moves? Then you don't need any of this special handling. In fact the delay slot filling will likely move the preserve SP logic into the delay slot as you would like it to be.
tom
On Apr 9, 2010, at 1:22 AM, Christian Thalinger wrote:
> On Thu, 2010-04-08 at 12:01 -0700, Tom Rodriguez wrote:
>> It says that lir_dynamic_call already has a filled delay slot but I
>> don't see where that's happening. If there's special work that should
>> be inserted in the delay slot then I think it should be inserted here.
>> Otherwise this looks ok.
>
> Oops, thanks. I missed something during the merge. I updated the
> webrev.
>
> -- Christian
>
More information about the hotspot-compiler-dev
mailing list