Review Request: Improved Zero crash dump

[Gary Benson]

Christian Thalinger wrote:
> On Thu, 2010-04-15 at 16:34 +0100, Gary Benson wrote:
> > Christian Thalinger wrote:
> > > On Thu, 2010-04-15 at 15:59 +0100, Gary Benson wrote:
> > > > Christian Thalinger wrote:
> > > > > On Thu, 2010-04-15 at 15:46 +0100, Gary Benson wrote:
> > > > > > Christian Thalinger wrote:
> > > > > > > On Wed, 2010-04-14 at 13:27 +0100, Gary Benson wrote:
> > > > > > > > While investigating a GC crash I noticed that the stack was
> > > > > > > > dumped differently to other crashes.  This webrev fixes:
> > > > > > > > 
> > > > > > > >   http://cr.openjdk.java.net/~gbenson/zero-gc-crash-dump/
> > > > > > > > 
> > > > > > > > I don't have a bug id for this.
> > > > > > > 
> > > > > > > FTR, as discussed on IRC we should factor the code into a method 
> > > > > > > to avoid code duplication.
> > > > > > 
> > > > > > How about this:
> > > > > > 
> > > > > >   http://cr.openjdk.java.net/~gbenson/zero-gc-crash-dump-2/
> > > > > 
> > > > > Looks good.  What about the copyright?
> > > > 
> > > > What should I do to it, update the Sun one, or add a Red Hat line?
> > > 
> > > As you like.  If you just want to update the Sun one I can do that for
> > > you when I commit it.
> > 
> > Please.
> 
> 6944503: Improved Zero crash dump
> 
> It's submitted.

Cool, thanks.

Cheers,
Gary

-- 
http://gbenson.net/