Request for reviews (M): 6930772: JSR 292 needs to support SPARC C1

[Tom Rodriguez]

Why are you returning a LIR_Opr&?

tom

On Apr 21, 2010, at 12:24 PM, Christian Thalinger wrote:

> On Wed, 2010-04-21 at 21:16 +0200, Christian Thalinger wrote:
>> On Wed, 2010-04-21 at 12:12 -0700, John Rose wrote:
>>> On Apr 21, 2010, at 2:22 AM, Christian Thalinger wrote:
>>> 
>>>> Looking at the C2 changes this wouldn't cover all uses, e.g.:
>>>> 
>>>> !   return L7_REGP_mask;
>>> 
>>> In some cases an extra assert can apply the constant to the usage.  At
>>> least a comment will give applicability to "grep".
>> 
>> Right, I did that in the C1 FrameMap too.  I'll post new C1 and C2
>> webrevs.
> 
> http://cr.openjdk.java.net/~twisti/6930772/webrev.04/
> 
> -- Christian
>