review (S) for 6943485: JVMTI always on capabilities change code generation too much

[Tom Rodriguez]

On Apr 22, 2010, at 11:58 AM, daniel.daugherty at oracle.com wrote:

> On 4/20/2010 4:39 PM, Tom Rodriguez wrote:
>> http://cr.openjdk.java.net/~never/6943485
>>  
> 
> Summary: thumbs up
> 
> I updated the bug comments with some code history stuff.

Thanks.

> src/share/vm/opto/c2compiler.cpp
>   So it's okay to EscapeAnalysis when redefining classes?

I believe so.  If the methods are redefined then the code should be invalidated and recompiled.  There might be one place where we need an evol dependency but I need to check into that.  We had previously been running all the JVMTI tests with EA enabled at various points and hadn't seen any issues.

> 
> src/share/vm/opto/compile.cpp
>   No comments.
> 
> src/share/vm/opto/compile.hpp
>   No comments.
> 
> src/share/vm/opto/graphKit.cpp
>   No comments.
> 
> src/share/vm/prims/jvmtiExport.cpp
>   No comments.
> 
> src/share/vm/prims/jvmtiExport.hpp
>   No comments.
> 
> src/share/vm/prims/jvmtiManageCapabilities.cpp
>   In addition to can_generate_breakpoint_events, the
>   can_generate_frame_pop_events should be queried also when
>   setting can_access_local_variables.

Why?

tom