Request for reviews (M): 6930772: JSR 292 needs to support SPARC C1

Christian Thalinger Christian.Thalinger at Sun.COM
Mon Apr 26 05:30:42 PDT 2010


On Mon, 2010-04-26 at 12:27 +0200, Christian Thalinger wrote:
> On Fri, 2010-04-23 at 10:23 -0700, Tom Rodriguez wrote:
> > On Apr 23, 2010, at 6:45 AM, Christian Thalinger wrote:
> > 
> > > On Wed, 2010-04-21 at 12:31 -0700, Tom Rodriguez wrote:
> > >> Why are you returning a LIR_Opr&?
> > > 
> > > Because the do_temp call in LIR_OpVisitState::visit requires it.
> > 
> > You should paper over that locally with a temp instead of polluting
> > FrameMap with that constraint.
> 
> OK.
> 
> http://cr.openjdk.java.net/~twisti/6930772/webrev.05/

That doesn't work, it hits an assert.  It seems the problem happens
because the local temporary reference goes dead and then an assert is
hit somewhere in the register allocator.

The only way I can see to make this work is to put the temporary into
LIR_OpJavaCall.

-- Christian



More information about the hotspot-compiler-dev mailing list