Request for reviews (XL): 6829193: JSR 292 needs to support SPARC

[Christian Thalinger]

On Fri, 2010-04-23 at 15:46 -0700, John Rose wrote:
> On Apr 23, 2010, at 10:22 AM, Tom Rodriguez wrote:
> 
> >> 
> >> void regcon_sll_ptr(RegisterOrConstant s1, RegisterOrConstant s2, RegisterOrConstant d);
> > 
> > I'd be ok with that for sparc, though I think you still need the
> temp if dest and src were both constants that were larger than a
> simm13.

Yes, a temp is required.  I missed that above.

> 
> *And* the destination value has to be passed by-reference, because if
> the temp is used for materialization, the updated destination will
> have to be passed back out to the caller.

Right.  Here is the change:

http://cr.openjdk.java.net/~twisti/6829193/webrev.05/

I like that much more.

-- Christian