Request for reviews (XL): 6829193: JSR 292 needs to support SPARC

Tom Rodriguez tom.rodriguez at oracle.com
Tue Apr 27 11:01:26 PDT 2010


>> 
>> It's better but I still don't like the value return parameter.  Almost
>> every path through there changes the value of dest and that seems like
>> something that should be directly returned.  If it always produced its
>> result in a register then I think it should follow the pattern of
>> sll_ptr but since it doesn't I think it should follow a different
>> pattern.
> 
> Last try :-)
> 
> http://cr.openjdk.java.net/~twisti/6829193/webrev.06/

That looks good.

tom

> 
> -- Christian
> 



More information about the hotspot-compiler-dev mailing list