Short/Character.reverseBytes intrinsics

Ulf Zibis Ulf.Zibis at gmx.de
Tue Apr 27 15:07:38 PDT 2010


Am 27.04.2010 19:29, schrieb Hiroshi Yamauchi:
> Tom,
>
> Thanks. It looks like it's been checked in.
>
>    http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/d7f654633cfe
>
> Now, Martin and Ulf, the following patch is up to you:
>
>    http://cr.openjdk.java.net/~martin/webrevs/openjdk7/nioBits.java/
>    

Looks perfect to me.

Maybe you like to rename char variables to c, integers to i etc., just 
for sugar.

I'm not sure, if starting at offset 7/3/1 and then decrementing down to 
0 is the fastest way to step through the multi-byte values in makeType 
and get/putTypeL/B methods. They are anyway intrinsified little later. 
My guess is, we could save byte code and JIT optimization load by 
defining those methods as native calls, and user will not be confused, 
if those methods will perform slow on assembling the multi-byte values 
from single bytes.

-Ulf




More information about the hotspot-compiler-dev mailing list