Request for reviews (XXL): 6961690: load oops from constant table on SPARC
Christian Thalinger
christian.thalinger at oracle.com
Wed Dec 1 02:51:02 PST 2010
On Nov 30, 2010, at 7:02 PM, Vladimir Kozlov wrote:
> Looks good. Add the assert into MachConstantBaseNode::emit sparc code.
http://cr.openjdk.java.net/~twisti/6961690/webrev.05/
The only change is this additional assert in SPARC's MachConstantBaseNode::emit:
+ // For the following RDPC logic to work correctly the consts
+ // section must be allocated right before the insts section. This
+ // assert checks for that. The layout and the SECT_* constants
+ // are defined in src/share/vm/asm/codeBuffer.hpp.
+ assert(CodeBuffer::SECT_CONSTS + 1 == CodeBuffer::SECT_INSTS, "must be");
-- Christian
More information about the hotspot-compiler-dev
mailing list