Request for reviews (S): 7003798: test/compiler/6991596 fails with true != false

Tom Rodriguez tom.rodriguez at oracle.com
Thu Dec 2 10:58:27 PST 2010


Looks good.

tom

On Dec 2, 2010, at 6:51 AM, Christian Thalinger wrote:

> http://cr.openjdk.java.net/~twisti/7003798/webrev.01/
> 
> 7003798: test/compiler/6991596 fails with true != false
> Summary: The test of 6991596 fails on SPARCV9.
> Reviewed-by:
> 
> It seems I have never verified the test of 6991596 with 64-bit SPARC.  
> On SPARCV9 a long has two 64-bit interpreter slots but the value is
> passed only in one slot.  The current code does not handle this.
> 
> Add LP64 specific code that removes the empty slot and chooses the
> right one for conversion.
> 
> Tested with test of 6991596.
> 
> Additionally I enhanced the testcase to have better debugging support
> (-DDEBUG=true) and changed the method handle call sites to use the new
> syntax.



More information about the hotspot-compiler-dev mailing list