'ciConstant' and 'ciField' unnecessarily declare 'print_impl()' method

[Volker Simonis]

Well, I found 58 occurences of "#if 0".
I don't want to say that they are all useless, but probably very few
people remember what  they are good for:)

Have you considered them for removal?

On Fri, Dec 10, 2010 at 6:46 PM, Tom Rodriguez <tom.rodriguez at oracle.com> wrote:
>
> On Dec 10, 2010, at 6:44 AM, Volker Simonis wrote:
>
>> Hi,
>>
>> while debugging I just realized that the two classes 'ciConstant' and
>> 'ciField' unnecessarily declare a 'print_impl()' method which is never
>> defined nor called. They have probably been declared there because the
>> two class names suggest that the classes are derived from 'ciObject'
>> but that's not the case.
>>
>> To avoid further confusion I'd suggest to simply remove the two
>> declarations. If somebody will open a bug I'll volunteer to submit the
>> patch.
>> But perhaps it's easier to remove the two useless declarations as part
>> of another change to save bug IDs:)
>
> I've been accumulating some dead code changes so I'll add these to it.  Any other dead things or thing that you suspect are dead?
>
> tom
>
>>
>> Regards,
>> Volker
>
>