review (XS) for 6765546: Wrong sscanf used to parse CompilerOracle command >= 32 characters could lead to crash
Vladimir Kozlov
vladimir.kozlov at oracle.com
Tue Dec 14 16:01:57 PST 2010
Good.
Vladimir
Tom Rodriguez wrote:
> http://cr.openjdk.java.net/~never/6765546
>
> 6765546: Wrong sscanf used to parse CompilerOracle command >= 32 characters could lead to crash
> Reviewed-by:
>
> The buffer for a sscanf isn't long enough to include the null
> termination and we're missing a check for unknown commands. Tested
> with various command lines.
More information about the hotspot-compiler-dev
mailing list