review (S) for

Vladimir Kozlov vladimir.kozlov at oracle.com
Wed Dec 15 14:50:02 PST 2010


Looks good.

+     // There no known reason why this should occur but just in case...
               ^ is

What could be the case when assigned_regHi() == -1 but assigned_reg() != -1 (num == 2)?

Vladimir

Tom Rodriguez wrote:
> http://cr.openjdk.java.net/~never/6579789
> 
> 6579789: Internal error "c1_LinearScan.cpp:1429 Error: assert(false,"")" in debuggee with fastdebug VM
> Reviewed-by:
> 
> When using the x86 FPU, spilling at an exception entry point may
> mutate the intervals so that _sorted_intervals is no longer sorted.
> The fix is detect this case and resort as needed.  Additionally I
> added some more assertion checks and fixed a printing problem that
> would assert on partially allocated intervals.  Tested with new test
> case and CTW.


More information about the hotspot-compiler-dev mailing list