review request (L): 7001424: implement JSR 292 EG adjustments, November 2010

[Christian Thalinger]

On Dec 16, 2010, at 1:04 PM, John Rose wrote:
> This is a JDK-only change request, in response to the last several weeks of JSR 292 EG work.
> 
> http://cr.openjdk.java.net/~jrose/7001424/webrev.00/
> 
> May I have an eyeball or two, please?
> 
> Thanks,

src/share/classes/java/dyn/ClassValue.java:

  93      * If no value has yet been computed, it is obtained by
  94      * by an invocation of the {@link #computeValue computeValue} method.

Superfluous "by".

src/share/classes/java/dyn/MethodHandle.java:

 241  * This is true even if the method handle is published through a shared
 242  * variables in a data race.

        ^variable

 651      * If the implementation is faced is able to prove that an equivalent
 652      * type handler call has already occurred (on the same two arguments),

I'm not sure this is correct: "is faced is able"

 331          * <li>If no access is allowed, the suffix is "/noaccess".
 332          * <li>If only public access is allowed, the suffix is "/public".
 333          * <li>If only public and package access are allowed, the suffix is "/package".
 334          * <li>If only public, package, and private access are allowed, the suffix is "/private".

I don't understand this.  Why is the suffix "/private" if public access is allowed?

src/share/classes/java/dyn/MethodType.java:

  73  * in a class file's constant pool as constants. The may be loaded by an {@code ldc}

"The may be" seems wrong.  "They" or "The entry"?

 316      * @param ptypesToInsert zero or more a new parameter types to insert after the end of the parameter list

"more a new", is this correct?

 533      * If a type name name is array, it the base type followed

There is obviously something wrong.

src/share/classes/java/dyn/package-info.java:

 189  * If the resoultion succeeds, the same object reference is produced

Typo.

src/share/classes/java/dyn/Switcher.java:

  43  * The invalidation is also permanent, which means the switcher
  44  * 

What about the switcher?  It just became interesting... ;-)

-- Christian