Request for reviews (M): 7007377: JSR 292 MethodHandlesTest.testCastFailure fails on SPARC with -Xcomp +DeoptimizeALot

Vladimir Kozlov vladimir.kozlov at oracle.com
Tue Dec 21 10:26:03 PST 2010


Looks good for me.

Vladimir

Christian Thalinger wrote:
> http://cr.openjdk.java.net/~twisti/7007377/webrev.01/
> 
> 7007377: JSR 292 MethodHandlesTest.testCastFailure fails on SPARC with -Xcomp +DeoptimizeALot
> Reviewed-by:
> 
> To throw an exception _raise_exception calls the Java method
> MethodHandleImpl.raiseException.  In order to do so it has to set up
> an interpreter state including an interpreter stack frame.  That logic
> is broken.
> 
> To avoid duplication of that set up logic, _raise_exception can
> instead use a C2I adapter that does the set up.  This makes the
> _raise_exception adapter simpler as the arguments only need to be
> passed in the compiler argument registers.  Since this is a slow
> path anyway performance should not be a problem.
> 
> Tested with MethodHandlesTest.
> 


More information about the hotspot-compiler-dev mailing list