Request for reviews (S): 6923043: failed nightly tests which use -XX:+PrintCompilation -Xcomp -XX:CompileOnly

[Tom Rodriguez]

On Feb 3, 2010, at 2:08 PM, Vladimir Kozlov wrote:

> Tom Rodriguez wrote:
>> Which test did this cause to fail?  I think it would be better for the default to be reporting, particularly since  I think you missed a couple in compilerBroker that should be reported.  Maybe we should add set_not_compilable_quietly for use by the various oracle routines that supplies the correct arguments.
> 
> You are right, I missed few cases. I set the default to report.
> 
> http://cr.openjdk.java.net/~kvn/6923043/webrev.01
> 
> I don't think we should add global set_not_compilable_quietly since the methods
> which are still compilable could be deoptimized and we want report the case.

I meant that we should add:

void set_not_compilable_quietly(int comp_level = CompLevel_highest_tier) {
  set_not_compilable(comp_level, false);
}

so you don't have to guess what false means.

tom

> 
> 
> Test failed because it greps output for Exception:
> 
> test/closed/compiler/4903383/Test4903383.sh
> 
> made not compilable  java.lang.Thread::<init> (49 bytes)
> made not compilable  java.lang.System::getProperty (25 bytes)
> ...
> made not compilable  java.lang.Exception::<init> (7 bytes)

> ------------------------------------
> grep "java.lang.Exception" test.out
> 
> if [ $? = 0 ]
> then
>    echo "Test Failed"
>    exit 1
> else
>    echo "Test Passed"
>    exit 0
> fi
> -----------------------------------
> 
> Thanks,
> Vladimir
> 
>> tom
>> On Feb 3, 2010, at 12:41 PM, Vladimir Kozlov wrote:
>>> http://cr.openjdk.java.net/~kvn/6923043/webrev
>>> 
>>> Fixed 6923043: failed nightly tests which use -XX:+PrintCompilation -Xcomp -XX:CompileOnly
>>> 
>>> The intention of changes in 6614597 was to print "made not compilable" line
>>> for methods for which compilation was disabled due to frequent deoptimizations.
>>> But it prints such line also for methods for which compilation was disabled
>>> due to CompilerOracle options (Exclude, CompileOnly, CIStart, CIStop).
>>> 
>>> The fix is to path flag to methodOopDesc::set_not_compilable() to print
>>> the line only for deoptimizations.
>>> 
>>> Reviewed by:
>>> 
>>> Fix verified (y/n): y, failed test
>>> 
>>> Other testing:
>>> JPRT
>>>