Request for reviews (XXS): 6924097: assert((_type == Type::MEMORY) == (_adr_type != 0),"adr_type for memory phis only")

Tom Rodriguez Thomas.Rodriguez at Sun.COM
Mon Feb 8 11:45:01 PST 2010


Looks good.

tom

On Feb 7, 2010, at 12:18 PM, Vladimir Kozlov wrote:

> http://cr.openjdk.java.net/~kvn/6924097/webrev
> 
> Fixed 6924097: assert((_type == Type::MEMORY) == (_adr_type != 0),"adr_type for memory phis only")
> 
> Problem:
> PhaseIdealLoop::split_thru_phi() does not set adr_type when creates new memory Phi node.
> 
> Solution:
> PhiNode::make_blank(r, n) method to construct the phi.
> 
> Reviewed by:
> 
> Fix verified (y/n): y, test
> 
> Other testing:
> JPRT
> 



More information about the hotspot-compiler-dev mailing list