Request for reviews (S): 6925249: assert(last_sp < (intptr_t*) interpreter_frame_monitor_begin(),"bad tos")

[Vladimir Kozlov]

Thank you, Christian

Vladimir

On 2/12/10 2:37 AM, Christian Thalinger wrote:
> On 02/11/10 09:32 PM, Vladimir Kozlov wrote:
>> http://cr.openjdk.java.net/~kvn/6925249/webrev
>>
>> Fixed 6925249: assert(last_sp<  (intptr_t*) interpreter_frame_monitor_begin(),"bad tos")
>>
>> Problem:
>> Assert triggered when printing debug information for top deoptimized frame.
>> Such frame has last_sp == interpreter_frame_monitor_end if there is no
>> expressions and interpreter_frame_monitor_end == interpreter_frame_monitor_begin
>> if there are no monitors.
>>
>> Solution:
>> Fix assert. There is also misleading printing for stack expressions for middle
>> deoptimized frames since it prints value of passed arguments to callee frame
>> which is not initialized at the time of printing. But I decided don't touch
>> any structures and values in vframe and iframe since they work and the problem
>> only with printing.
>> Also did some cleanup and removed printing create_vframeArray since values are
>> still not initialized.
>>
>> Reviewed by:
>>
>> Fix verified (y/n): y, test
>>
>> Other testing:
>> JPRT
>>
>
> Looks good.  -- Christian