Request for reviews (S): 6926782: CodeBuffer size too small after 6921352

Vladimir Kozlov Vladimir.Kozlov at Sun.COM
Tue Feb 16 09:46:53 PST 2010


Christian,

I thought you will set the flag during parsing because
it could be helpful to know that call site is MH during whole
compilation. Is it possible?
Adding size for MH should be also under MH check.

Thanks,
Vladimir

On 2/16/10 5:05 AM, Christian Thalinger wrote:
> http://cr.openjdk.java.net/~twisti/6926782/webrev.01/
> 	
> In the changes for 6921352 I forgot to increase the CodeBuffer size
> and thus we sometimes get an assert when generating code:
>
> # Internal Error
> (/tmp/jprt/P1/B/233753.kvn/source/src/share/vm/asm/codeBuffer.hpp:169),
> pid=26304, tid=3011459984
> # Error: assert(allocates2(pc),"")
>
> The fix is to increase the CodeBuffer size.  Additionally I changed
> the code to emit the deopt MH handler only when it's required.
>
> -- Christian


More information about the hotspot-compiler-dev mailing list