Request for reviews (XS): 6926697: "optimized" VM build failed: The type "AdapterHandlerTableIterator" is incomplete
Tom Rodriguez
Thomas.Rodriguez at Sun.COM
Tue Feb 16 16:06:14 PST 2010
That looks good.
tom
On Feb 16, 2010, at 3:46 PM, Vladimir Kozlov wrote:
> I changed it to NOT_PRODUCT since it is used to collect statistics
> and I updated webrev.
>
> Vladimir
>
> Vladimir Kozlov wrote:
>> Thank you, Tom
>> I will rework the change.
>> Vladimir
>> Tom Rodriguez wrote:
>>> I'd rather have that whole section ifdef ASSERT or make AdapterHandlerTableIterator ifdef PRODUCT. Having contains always return false just seems wrong.
>>>
>>> tom
>>>
>>> On Feb 16, 2010, at 10:50 AM, Vladimir Kozlov wrote:
>>>
>>>> http://cr.openjdk.java.net/~kvn/6926697/webrev
>>>>
>>>> Fixed 6926697: "optimized" VM build failed: The type "AdapterHandlerTableIterator" is incomplete
>>>>
>>>> Problem:
>>>> AdapterHandlerTableIterator is defined only in debug VM
>>>> but it is used in all non product VM versions.
>>>>
>>>> Solution:
>>>> Use AdapterHandlerTableIterator only in debug VM.
>>>>
>>>> Reviewed by:
>>>>
>>>> Fix verified (y/n): y, build
>>>>
>>>> Other testing:
>>>> JPRT
>>>>
>>>
More information about the hotspot-compiler-dev
mailing list