Review Request: Zero S/390 fixes
Gary Benson
gbenson at redhat.com
Thu Feb 18 06:09:57 PST 2010
Christian Thalinger wrote:
> On Wed, 2010-02-17 at 11:21 +0000, Gary Benson wrote:
> > Christian Thalinger wrote:
> > > On 02/17/10 10:04 AM, Gary Benson wrote:
> > > > This webrev fixes two failures on 31-bit S/390:
> > > >
> > > > http://cr.openjdk.java.net/~gbenson/zero-s390-fixes-01/
> > > >
> > > > The first is that there were not enough shadow pages for a
> > > > StackOverflowError to be thrown. The second is the
> > > > implementation of a 64-bit atomic copy such that long and
> > > > double fields in objects are got and set atomically.
> > > >
> > > > I don't have a bug id for this.
> > >
> > > I filed:
> > >
> > > 6927165: Zero S/390 fixes
> > >
> > > The changes look good and I will push them for you.
> >
> > Thank you :)
>
> For the record, Gary found out that the fix is not completely
> correct and I killed the push job. We are waiting for the right
> fix.
Yeah, my S/390 assembler isn't as hot as I thought it was...
This one's better :)
http://cr.openjdk.java.net/~gbenson/zero-s390-fixes-02/
Cheers,
Gary
--
http://gbenson.net/
More information about the hotspot-compiler-dev
mailing list