review (S) for 6915557: assert(_gvn.type(l)->higher_equal(type), "must constrain OSR typestate") with debug build
Tom Rodriguez
Thomas.Rodriguez at Sun.COM
Wed Feb 24 17:29:22 PST 2010
http://cr.openjdk.java.net/~never/6915557
6915557: assert(_gvn.type(l)->higher_equal(type),"must constrain OSR typestate") with debug build
Reviewed-by:
The fix for 6892079 to eliminate asserts about address types in OSR
was insufficient because sometimes method liveness may consider locals
to live that actually aren't because of the conservativeness of its
analysis. I think the fix is simply to not check address types. If
the OSR entry point has any live address we will fail this test but
the resonsibility for making sure that we don't actually have a live
jsr during OSR entry is managed by ciTypeFlow itself so it should be
safe to simply skip the check. Tested with failing test case.
src/share/vm/opto/parse1.cpp
More information about the hotspot-compiler-dev
mailing list