Request for reviews (S): 6930116: loop predication code does not handle If nodes with only one projection

Tom Rodriguez Thomas.Rodriguez at Sun.COM
Thu Feb 25 19:21:04 PST 2010


Looks good.

tom

On Feb 25, 2010, at 7:13 PM, Vladimir Kozlov wrote:

> http://cr.openjdk.java.net/~kvn/6930116/webrev
> 
> Fixed 6930116: loop predication code does not handle If nodes with only one projection
> 
> Problem:
> Loop predication codes expects all If nodes have 2 projections which
> could be not true for some dead paths.
> 
> Solution:
> Add check for iff->outcnt() < 2.
> 
> Reviewed by:
> 
> Fix verified (y/n): y
> 
> Other testing:
> JPRT
> 
> I did not find where such If came from but other places has such check.
> It could came from some loop optimization and was not removed since
> IGVN cleaning code was not run yet (it is done at the end of all
> loop optimizations).
> 



More information about the hotspot-compiler-dev mailing list