Request for reviews (XL): 6894206: JVM needs a way to traverse method handle structures

Christian Thalinger Christian.Thalinger at Sun.COM
Mon Jan 4 07:00:39 PST 2010


On Wed, 2009-12-16 at 18:49 +0100, Christian Thalinger wrote:
> I forgot that this changeset does not build on Windows and I have to fix
> that first.  I will post a new webrev when I have a solution.

With the help of Ivan Krylov (thanks for doing the Windows builds) I
could fix the build problem:

diff -r a675ffc41972 src/share/vm/prims/methodHandleWalk.cpp
--- a/src/share/vm/prims/methodHandleWalk.cpp
+++ b/src/share/vm/prims/methodHandleWalk.cpp
@@ -756,6 +756,7 @@ public:
       _out->print("%s", ret);
       _out->print(_verbose ? "\n}\n" : " }");
     }
+    return ArgToken();
   }
 
   virtual void set_method_handle(oop mh) {
diff -r a675ffc41972 src/share/vm/prims/methodHandleWalk.hpp
--- a/src/share/vm/prims/methodHandleWalk.hpp
+++ b/src/share/vm/prims/methodHandleWalk.hpp
@@ -108,6 +108,7 @@ public:
   struct SlotState {
     BasicType _type;
     ArgToken  _arg;
+    SlotState() : _type(), _arg() {}
   };
   static SlotState make_state(BasicType type, ArgToken arg) {
     SlotState ss;

Here is the final webrev:

http://cr.openjdk.java.net/~twisti/6894206/webrev.05/

I will push this one now.

-- Christian



More information about the hotspot-compiler-dev mailing list