build error on linux, nmethod.cpp

[Deneau, Tom]

Tom --

Yes, I never had any other build problems before this one.

-- Tom D.

-----Original Message-----
From: Thomas.Rodriguez at Sun.COM [mailto:Thomas.Rodriguez at Sun.COM] 
Sent: Tuesday, January 05, 2010 4:31 PM
To: Deneau, Tom
Cc: hotspot-compiler-dev at openjdk.java.net compiler
Subject: Re: build error on linux, nmethod.cpp

So I tried testing my fix against 4.1.3 by first compiling it without the fix and hotspot didn't build at all because it compiled with -Wconversion.  I'm running:

gcc version 4.1.3 20080623 (prerelease) (Ubuntu 4.1.2-23ubuntu3)

I modified the logic in make/linux/makefiles/gcc.make to leave out -Wconversion for 4.1 in addition to 4.3 and it builds ok.  So 4.1 seems kind of inconsistent about it's handling of warnings.  Are you able to compile with your version of 4.1.2, aside from the unsigned issue I introduced?

tom

On Jan 4, 2010, at 5:09 AM, Christian Thalinger wrote:

> On Sat, 2010-01-02 at 06:11 -0800, Deneau, Tom wrote:
>> When I pulled from http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot
>> and then tried to compile on linux, I got the following new error...
>> 
>>  cc1plus: warnings being treated as errors
>>  /hotspot-comp-latest/src/share/vm/code/nmethod.cpp: In member function 'bool nmethod::make_not_entrant_or_zombie(int)':
>>  /hotspot-comp-latest/src/share/vm/code/nmethod.cpp:1197: warning: comparison between signed and unsigned integer expressions
>> 
>> I am using
>>   gcc version 4.1.2 20070502 (Red Hat 4.1.2-12)
>> 
>> # hg tip
>> changeset:   1102:1ea456c6f2b7
>> tag:         tip
>> parent:      1101:cf9a9a50e763
>> parent:      1098:032260830071
>> user:        iveresov
>> date:        Tue Dec 22 17:56:03 2009 -0800
>> summary:     Merge
> 
> This was introduced by:
> 
> http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/032260830071
> 
> Maybe we should change the argument type to unsigned int.
> 
> -- Christian
>