review (S) for 6909839: missing unsigned compare cases for some cmoves in sparc.ad

John Rose John.Rose at Sun.COM
Wed Jan 6 12:54:25 PST 2010


On Jan 6, 2010, at 12:26 PM, Tom Rodriguez wrote:

> http://cr.openjdk.java.net/~never/6909839

Looks good.  You might consider changing the pre-existing cmovII_U to cmovIIu for consistency.

Also, did you intend to omit cmovNIu?  Your test case (or similar cases) could possibly fail in compressed oops VMs.

-- John


More information about the hotspot-compiler-dev mailing list