Request for reviews (S): 6914622: Print values of all flags for product VM

Vladimir Kozlov Vladimir.Kozlov at Sun.COM
Wed Jan 6 15:02:01 PST 2010


Y. Srinivas Ramakrishna wrote:
>>> (2) I would personally be inclined to delete Xprintflags since it's
>>>     not a product flag and can therefore, it seems to me, be deleted
>>>     without approval.  Why have duplicate functionality/interfaces
>>>     even if the duplication is only in debug mode.
>>
>> I doubt we can do it now since you can google it :).
> 
> Does that apply to even flags that are not exposed in the product build?
> 
> Besides, that would mean that _any_ flag change would need approval
> because with open source you can google (or bing :) all the code
> and of course this email (on the openjdk list) which contains that 
> string :-)

Google hits show that people know and use it. So I don't want to delete it.
It would be nice just make it product instead of adding new flag.

And we have other flags duplications, for example

-Xbatch and XX:-BackgroundCompilation

Vladimir

> 
> -- ramki
> 
>>
>> Thanks,
>> Vladimir
>>
>>>
>>> Otherwise looks good.
>>> -- ramki
>>>
>>> On 01/06/10 14:13, Vladimir Kozlov wrote:
>>>>
>>>> http://cr.openjdk.java.net/~kvn/6914622/webrev
>>>>
>>>> Fixed 6914622: Print values of all flags for product VM
>>>>
>>>> Change the flag -XX:+PrintFlagsFinal to product.
>>>> Add new product flag -XX:+PrintFlagsInitial to print all VM flags 
>>>> before
>>>> arguments processing, it is duplicate of debug flag -Xprintflags.
>>>> Move all related print flags together.
>>>>
>>>> Partially contributed by: Gary Benson
>>>> Note, the changes are different from suggested by Gary Benson
>>>> since I can't change -Xprintflags without approval, so I added
>>>> new option instead.
>>>>
>>>> Reviewed by:
>>>>
>>>> Fix verified (y/n): y
>>>>
>>>> Other testing:
>>>> JPRT
>>>>
>>>
> 


More information about the hotspot-compiler-dev mailing list