Request for review (M): 6914206: change way of permission checking for generated MethodHandle adapters
Christian Thalinger
Christian.Thalinger at Sun.COM
Thu Jan 7 06:33:36 PST 2010
On Tue, 2010-01-05 at 10:56 -0800, Vladimir Kozlov wrote:
> Why you not did it?:
>
> // FIXME: Hide this match logic in methodOopDesc or MethodHandleCompiler.
Fixed. I added one test in methodOopDesc and the klass test in
MethodHandleCompiler because of dependencies.
> Should you also check for EnableMethodHandles flag in new code?
Should we? I don't think it's necessary.
> The next code fix only rbt. What about _rtype == T_ARRAY?
>
> + if (rbt == T_ARRAY) rbt = T_OBJECT;
Thanks, I added that.
Here is the new webrev:
http://cr.openjdk.java.net/~twisti/6914206/webrev.02/
-- Christian
More information about the hotspot-compiler-dev
mailing list