review (S) for 6849984: Value methods for platform dependent math functions constant fold incorrectly

[Vladimir Kozlov]

src/share/vm/runtime/stubRoutines.hpp
+   // These are versions of the java.lang.Math methods perform the same
                                                        ^ which ?
+   // version returns the same result as the the strict version then
                                               ^ dup
+   // the they can be set to the appropriate function from SharedRuntime.
         ^

src/share/vm/opto/subnode.cpp
Did you tested on sparc where all StubRoutines::intrinsic_* are NULL?
I don't see their initialization on sparc.

cpu/x86/vm/stubGenerator_x86_64.cpp
Use movdbl() instead of movsd().

+       StubCodeMark mark(this, "StubRoutines", "cos");
...
+       __ movsd(xmm0, Address(rsp, 0));
+       __ addq(rsp, 8);
+       __ fld_d(Address(rsp, 4)); <<<<<<  What is that???
+       __ ret(0);
+     }

Vladimir

Tom Rodriguez wrote:
> http://cr.openjdk.java.net/~never/6849984