review (S) for 6911204: generated adapters with large signatures can fill up the code cache

[Vladimir Kozlov]

src/share/vm/runtime/sharedRuntime.cpp

1783 // A simple wrapper class around the calling convntion information
                                                      ^

1793   int value(int index) { <<< returns "int" but _fingerprint is array of intptr_t,
                                   and there is no check (v1 == (int) v1). I know they fit "int"
                                   but some compilers may complain about downcast without explicit cast.

I do not get next:
1806     _length = total_args_passed * sizeof(VMRegPair) / sizeof(int);
should it be :
1806     _length = total_args_passed * 2;
since you always stores 2 values per argument


1856     return st.as_string();;
                                ^

2039     if (UseNewCode2) { <<<<<<<<<<
2040       entry = NULL;
2041     }

Vladimir

Tom Rodriguez wrote:
> http://cr.openjdk.java.net/~never/6911204