review (S) for 6911204: generated adapters with large signatures can fill up the code cache

Vladimir Kozlov Vladimir.Kozlov at Sun.COM
Wed Jan 13 19:16:43 PST 2010


>>
>> 1793   int value(int index) {<<<  returns "int" but _fingerprint is array of intptr_t,
>>                                   and there is no check (v1 == (int) v1). I know they fit "int"
>>                                   but some compilers may complain about downcast without explicit cast.
>
> You're right.  I fixed it.

I thought you will use (int) cast. If value() returns intptr_t you will have
problems in compute_hash() and as_string(), especially last since print
format expects int value.

Vladimir

>
>
> tom
>
>
>>
>> Vladimir
>>
>> Tom Rodriguez wrote:
>>> http://cr.openjdk.java.net/~never/6911204
>


More information about the hotspot-compiler-dev mailing list