review (S) for 6849984: Value methods for platform dependent math functions constant fold incorrectly

[Vladimir Kozlov]

Christian Thalinger wrote:
> 
> It's a little strange to generate the math intrinsics along with the
> arraycopy stubs in:
> 
>   void generate_arraycopy_stubs() {

Yes, it could be new generate_math_stubs() but it be more changes.

> 
> Maybe I missed the point of this change, but why are we using the much
> more complicated C versions for these?
> 
> +     // The intrinsic version of these seem to return the same value as
> +     // the strict version.
> +     StubRoutines::_intrinsic_exp = SharedRuntime::dexp;
> +     StubRoutines::_intrinsic_pow = SharedRuntime::dpow;

There is no implementation of ExpD and PowD in x86_64.ad (which is surprise - we missed it???)
And it is also complex code - see it in x86_32.ad

Vladimir

> 
> Otherwise this looks good.
> 
> -- Christian
>